Port socketserver to use channels and JSON based protocol#19782
Draft
64-bitman wants to merge 24 commits intovim:masterfrom
Draft
Port socketserver to use channels and JSON based protocol#1978264-bitman wants to merge 24 commits intovim:masterfrom
64-bitman wants to merge 24 commits intovim:masterfrom
Conversation
d9aeb75 to
b4fca02
Compare
602d848 to
a203698
Compare
Contributor
Author
|
@pemensik Can you test if this PR fixes your issue? Thanks |
|
Note: JSON has a binary alternative in standardized CBOR protocol. It might be better suited for some binary blobs exchange. It can even represent JSON. |
a4ee703 to
5e8e11c
Compare
Contributor
Author
Well there is no need to exchange binary blobs so JSON works fine |
b620090 to
e5ea406
Compare
Contributor
Author
|
@chrisbra Would this PR be accepted/OK? Thanks |
7e7c435 to
632bf6b
Compare
6b76d92 to
bbd2afd
Compare
not needed since JSON is utf-8 anyways
Contributor
Author
|
@chrisbra just checking if you didn't see the previous comment |
bbd2afd to
0c00bfc
Compare
0c00bfc to
bef8bdf
Compare
bef8bdf to
e01b83b
Compare
Member
|
Yes I think this makes sense, even so this would be slightly backwards compatible. But I doubt this is a problem in practice as I have mentioned before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not backwards compatible with the old protocol, but I think it is worth it. Using JSON is much simpler instead of trying to understand some arcane custom binary protocol.