From f8ab4e1f21660de115654cef49d1c7636fd717fd Mon Sep 17 00:00:00 2001 From: Evan Sonderegger Date: Fri, 29 May 2020 10:04:30 -0400 Subject: [PATCH 1/2] Set MinGOP in bitmovin preset when GopMode is fixed --- internal/provider/bitmovin/bitmovin.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/internal/provider/bitmovin/bitmovin.go b/internal/provider/bitmovin/bitmovin.go index 03a846cf..161de6b1 100644 --- a/internal/provider/bitmovin/bitmovin.go +++ b/internal/provider/bitmovin/bitmovin.go @@ -227,6 +227,9 @@ func (p *bitmovinProvider) createH264VideoPreset(preset db.Preset, customData ma return nil, err } h264.MaxGOP = intToPtr(int64(gopSize)) + if preset.Video.GopMode == "fixed" { + h264.MinGOP = intToPtr(int64(gopSize)) + } } if preset.Video.BFrames != "" { bFrames, err := strconv.Atoi(preset.Video.BFrames) From 9892508f6e463d11218151d45c42241b0641eac3 Mon Sep 17 00:00:00 2001 From: Adam Sax Date: Wed, 21 Oct 2020 11:47:08 -0400 Subject: [PATCH 2/2] disable scenecut when in fixed GOP mode --- internal/provider/bitmovin/bitmovin.go | 1 + 1 file changed, 1 insertion(+) diff --git a/internal/provider/bitmovin/bitmovin.go b/internal/provider/bitmovin/bitmovin.go index 161de6b1..41ca518f 100644 --- a/internal/provider/bitmovin/bitmovin.go +++ b/internal/provider/bitmovin/bitmovin.go @@ -229,6 +229,7 @@ func (p *bitmovinProvider) createH264VideoPreset(preset db.Preset, customData ma h264.MaxGOP = intToPtr(int64(gopSize)) if preset.Video.GopMode == "fixed" { h264.MinGOP = intToPtr(int64(gopSize)) + h264.SceneCutThreshold = intToPtr(int64(0)) } } if preset.Video.BFrames != "" {