Ensure non-error thrown in getStaticPaths shows correctly (#33753)

ijjk · web-flow · commit 6aef15dc23df · 2022-01-27T16:31:54.000-06:00
diff --git a/packages/next/build/index.ts b/packages/next/build/index.ts
@@ -1028,7 +1028,7 @@ export default async function build(
                   )
                 }
               } catch (err) {
-                if (isError(err) && err.message !== 'INVALID_DEFAULT_EXPORT')
+                if (!isError(err) || err.message !== 'INVALID_DEFAULT_EXPORT')
                   throw err
                 invalidPages.add(page)
               }
diff --git a/test/integration/invalid-page-automatic-static-optimization/test/index.test.js b/test/integration/invalid-page-automatic-static-optimization/test/index.test.js
@@ -1,5 +1,6 @@
 /* eslint-env jest */
 
+import fs from 'fs-extra'
 import path from 'path'
 import { nextBuild } from 'next-test-utils'
 
@@ -15,4 +16,43 @@ describe('Invalid Page automatic static optimization', () => {
     expect(stderr).toMatch(/pages\/invalid/)
     expect(stderr).toMatch(/pages\/also-invalid/)
   })
+
+  it('handles non-error correctly', async () => {
+    const testPage = path.join(appDir, 'pages/[slug].js')
+    await fs.rename(path.join(appDir, 'pages'), path.join(appDir, 'pages-bak'))
+
+    await fs.ensureDir(path.join(appDir, 'pages'))
+    await fs.writeFile(
+      testPage,
+      `
+      export default function Page() {
+        return <p>hello world</p>
+      }
+      
+      export function getStaticPaths() {
+        throw 'invalid API token'
+      }
+      
+      export function getStaticProps() {
+        return {
+          props: {
+            hello: 'world'
+          }
+        }
+      }
+    `
+    )
+
+    try {
+      const { stderr } = await nextBuild(appDir, [], { stderr: true })
+      expect(stderr).toMatch(/invalid API token/)
+      expect(stderr).not.toMatch(/without a React Component/)
+    } finally {
+      await fs.remove(path.join(appDir, 'pages'))
+      await fs.rename(
+        path.join(appDir, 'pages-bak'),
+        path.join(appDir, 'pages')
+      )
+    }
+  })
 })

Original file line number	Diff line number	Diff line change
`@@ -1028,7 +1028,7 @@ export default async function build(`
`1028`	`1028`	`)`
`1029`	`1029`	`}`
`1030`	`1030`	`} catch (err) {`
`1031`		`- if (isError(err) && err.message !== 'INVALID_DEFAULT_EXPORT')`
	`1031`	`+ if (!isError(err) \|\| err.message !== 'INVALID_DEFAULT_EXPORT')`
`1032`	`1032`	`throw err`
`1033`	`1033`	`invalidPages.add(page)`
`1034`	`1034`	`}`