creating default instances for packer & unpacker config objects.

marenzo · marenzo · commit 13a33df41615 · 2016-04-06T17:30:58.000+03:00
this will reduce also the amount of created objects in application lifecycle, as they don't share state.
diff --git a/msgpack-core/src/main/java/org/msgpack/core/MessagePack.java b/msgpack-core/src/main/java/org/msgpack/core/MessagePack.java
@@ -37,6 +37,12 @@ public class MessagePack
 {
     public static final Charset UTF8 = Charset.forName("UTF-8");
 
+    /**
+     * Default packer/unpacker configurations
+     */
+    public static final PackerConfig DEFAULT_PACKER_CONFIG = new PackerConfig();
+    public static final UnpackerConfig DEFAULT_UNPACKER_CONFIG = new UnpackerConfig();
+
     /**
      * The prefix code set of MessagePack. See also https://github.com/msgpack/msgpack/blob/master/spec.md for details.
      */
@@ -138,7 +144,7 @@ private MessagePack()
      */
     public static MessagePacker newDefaultPacker(MessageBufferOutput out)
     {
-        return new PackerConfig().newPacker(out);
+        return DEFAULT_PACKER_CONFIG.newPacker(out);
     }
 
     /**
@@ -149,7 +155,7 @@ public static MessagePacker newDefaultPacker(MessageBufferOutput out)
      */
     public static MessagePacker newDefaultPacker(OutputStream out)
     {
-        return new PackerConfig().newPacker(out);
+        return DEFAULT_PACKER_CONFIG.newPacker(out);
     }
 
     /**
@@ -160,7 +166,7 @@ public static MessagePacker newDefaultPacker(OutputStream out)
      */
     public static MessagePacker newDefaultPacker(WritableByteChannel channel)
     {
-        return new PackerConfig().newPacker(channel);
+        return DEFAULT_PACKER_CONFIG.newPacker(channel);
     }
 
     /**
@@ -170,7 +176,7 @@ public static MessagePacker newDefaultPacker(WritableByteChannel channel)
      */
     public static MessageBufferPacker newDefaultBufferPacker()
     {
-        return new PackerConfig().newBufferPacker();
+        return DEFAULT_PACKER_CONFIG.newBufferPacker();
     }
 
     /**
@@ -181,7 +187,7 @@ public static MessageBufferPacker newDefaultBufferPacker()
      */
     public static MessageUnpacker newDefaultUnpacker(MessageBufferInput in)
     {
-        return new UnpackerConfig().newUnpacker(in);
+        return DEFAULT_UNPACKER_CONFIG.newUnpacker(in);
     }
 
     /**
@@ -192,7 +198,7 @@ public static MessageUnpacker newDefaultUnpacker(MessageBufferInput in)
      */
     public static MessageUnpacker newDefaultUnpacker(InputStream in)
     {
-        return new UnpackerConfig().newUnpacker(in);
+        return DEFAULT_UNPACKER_CONFIG.newUnpacker(in);
     }
 
     /**
@@ -203,7 +209,7 @@ public static MessageUnpacker newDefaultUnpacker(InputStream in)
      */
     public static MessageUnpacker newDefaultUnpacker(ReadableByteChannel channel)
     {
-        return new UnpackerConfig().newUnpacker(channel);
+        return DEFAULT_UNPACKER_CONFIG.newUnpacker(channel);
     }
 
     /**
@@ -214,7 +220,7 @@ public static MessageUnpacker newDefaultUnpacker(ReadableByteChannel channel)
      */
     public static MessageUnpacker newDefaultUnpacker(byte[] contents)
     {
-        return new UnpackerConfig().newUnpacker(contents);
+        return DEFAULT_UNPACKER_CONFIG.newUnpacker(contents);
     }
 
     /**
@@ -227,7 +233,7 @@ public static MessageUnpacker newDefaultUnpacker(byte[] contents)
      */
     public static MessageUnpacker newDefaultUnpacker(byte[] contents, int offset, int length)
     {
-        return new UnpackerConfig().newUnpacker(contents, offset, length);
+        return DEFAULT_UNPACKER_CONFIG.newUnpacker(contents, offset, length);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,12 @@ public class MessagePack`
`37`	`37`	`{`
`38`	`38`	`public static final Charset UTF8 = Charset.forName("UTF-8");`
`39`	`39`
	`40`	`+ /**`
	`41`	`+ * Default packer/unpacker configurations`
	`42`	`+ */`
	`43`	`+ public static final PackerConfig DEFAULT_PACKER_CONFIG = new PackerConfig();`
	`44`	`+ public static final UnpackerConfig DEFAULT_UNPACKER_CONFIG = new UnpackerConfig();`
	`45`	`+`
`40`	`46`	`/**`
`41`	`47`	`* The prefix code set of MessagePack. See also https://github.com/msgpack/msgpack/blob/master/spec.md for details.`
`42`	`48`	`*/`
`@@ -138,7 +144,7 @@ private MessagePack()`
`138`	`144`	`*/`
`139`	`145`	`public static MessagePacker newDefaultPacker(MessageBufferOutput out)`
`140`	`146`	`{`
`141`		`- return new PackerConfig().newPacker(out);`
	`147`	`+ return DEFAULT_PACKER_CONFIG.newPacker(out);`
`142`	`148`	`}`
`143`	`149`
`144`	`150`	`/**`
`@@ -149,7 +155,7 @@ public static MessagePacker newDefaultPacker(MessageBufferOutput out)`
`149`	`155`	`*/`
`150`	`156`	`public static MessagePacker newDefaultPacker(OutputStream out)`
`151`	`157`	`{`
`152`		`- return new PackerConfig().newPacker(out);`
	`158`	`+ return DEFAULT_PACKER_CONFIG.newPacker(out);`
`153`	`159`	`}`
`154`	`160`
`155`	`161`	`/**`
`@@ -160,7 +166,7 @@ public static MessagePacker newDefaultPacker(OutputStream out)`
`160`	`166`	`*/`
`161`	`167`	`public static MessagePacker newDefaultPacker(WritableByteChannel channel)`
`162`	`168`	`{`
`163`		`- return new PackerConfig().newPacker(channel);`
	`169`	`+ return DEFAULT_PACKER_CONFIG.newPacker(channel);`
`164`	`170`	`}`
`165`	`171`
`166`	`172`	`/**`
`@@ -170,7 +176,7 @@ public static MessagePacker newDefaultPacker(WritableByteChannel channel)`
`170`	`176`	`*/`
`171`	`177`	`public static MessageBufferPacker newDefaultBufferPacker()`
`172`	`178`	`{`
`173`		`- return new PackerConfig().newBufferPacker();`
	`179`	`+ return DEFAULT_PACKER_CONFIG.newBufferPacker();`
`174`	`180`	`}`
`175`	`181`
`176`	`182`	`/**`
`@@ -181,7 +187,7 @@ public static MessageBufferPacker newDefaultBufferPacker()`
`181`	`187`	`*/`
`182`	`188`	`public static MessageUnpacker newDefaultUnpacker(MessageBufferInput in)`
`183`	`189`	`{`
`184`		`- return new UnpackerConfig().newUnpacker(in);`
	`190`	`+ return DEFAULT_UNPACKER_CONFIG.newUnpacker(in);`
`185`	`191`	`}`
`186`	`192`
`187`	`193`	`/**`
`@@ -192,7 +198,7 @@ public static MessageUnpacker newDefaultUnpacker(MessageBufferInput in)`
`192`	`198`	`*/`
`193`	`199`	`public static MessageUnpacker newDefaultUnpacker(InputStream in)`
`194`	`200`	`{`
`195`		`- return new UnpackerConfig().newUnpacker(in);`
	`201`	`+ return DEFAULT_UNPACKER_CONFIG.newUnpacker(in);`
`196`	`202`	`}`
`197`	`203`
`198`	`204`	`/**`
`@@ -203,7 +209,7 @@ public static MessageUnpacker newDefaultUnpacker(InputStream in)`
`203`	`209`	`*/`
`204`	`210`	`public static MessageUnpacker newDefaultUnpacker(ReadableByteChannel channel)`
`205`	`211`	`{`
`206`		`- return new UnpackerConfig().newUnpacker(channel);`
	`212`	`+ return DEFAULT_UNPACKER_CONFIG.newUnpacker(channel);`
`207`	`213`	`}`
`208`	`214`
`209`	`215`	`/**`
`@@ -214,7 +220,7 @@ public static MessageUnpacker newDefaultUnpacker(ReadableByteChannel channel)`
`214`	`220`	`*/`
`215`	`221`	`public static MessageUnpacker newDefaultUnpacker(byte[] contents)`
`216`	`222`	`{`
`217`		`- return new UnpackerConfig().newUnpacker(contents);`
	`223`	`+ return DEFAULT_UNPACKER_CONFIG.newUnpacker(contents);`
`218`	`224`	`}`
`219`	`225`
`220`	`226`	`/**`
`@@ -227,7 +233,7 @@ public static MessageUnpacker newDefaultUnpacker(byte[] contents)`
`227`	`233`	`*/`
`228`	`234`	`public static MessageUnpacker newDefaultUnpacker(byte[] contents, int offset, int length)`
`229`	`235`	`{`
`230`		`- return new UnpackerConfig().newUnpacker(contents, offset, length);`
	`236`	`+ return DEFAULT_UNPACKER_CONFIG.newUnpacker(contents, offset, length);`
`231`	`237`	`}`
`232`	`238`
`233`	`239`	`/**`