Don't include the world in the published packages#2516
Merged
Conversation
We ended up including all sorts of stuff in our published packages. Let's take the opposite approach and include useful stuff rather than exclude unuseful stuff.
dbkr
approved these changes
Oct 26, 2016
| "start:prod": "parallelshell \"npm run start:emojione\" \"npm run start:js:prod\" \"npm run start:skins:css\" \"http-server -c 1 vector\"", | ||
| "clean": "rimraf build lib vector/olm.* vector/bundle.* vector/emojione", | ||
| "prepublish": "npm run build:css && npm run build:compile", | ||
| "prepublish": "npm run build:compile", |
Member
There was a problem hiding this comment.
I'm assuming this is actually part of the last PR, but ok :)
Member
Author
There was a problem hiding this comment.
yeah, pretty much. I just realised there was no point running build:css here.
dbkr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Oct 31, 2016
Include files explicitly rather than excluding them with .npmignore As element-hq/element-web#2516
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Nov 1, 2016
To avoid publishing whatever happens to be in the working copy. Equivalent of element-hq/element-web#2516 for react-sdk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ended up including all sorts of stuff in our published packages. Let's take
the opposite approach and include useful stuff rather than exclude unuseful
stuff.