Conversation
… so it can user email as well mx userId
|
Can one of the admins verify this patch? |
Member
Otherwise this is looking really good! Unsure whether to merge now and apply the cosmetic tweaks after the event or wait for this before cutting the freeze... |
Member
|
Final question: is a deliberate design that the 'User ID, Name or email' prompt is always on the last line, rather than flowing inline and moving over the autocomplete bar to match? (superficially, removing the width of the textarea, setting display: inline-block and putting a relative offset on the autocomplete bar seems to work) |
Member
|
(merged, although the stuff above still needs to be addressed somewhere) |
Member
|
moving the feedback to #1882 so it's not lost. |
3 tasks
t3chguy
pushed a commit
that referenced
this pull request
Mar 25, 2026
Deprecate ia32 Windows builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should close #2131 and some of #1758 . A companion branch matrix-org/matrix-react-sdk:wmwragg/chat-multi-invite also needs to be merged.
Signed-off-by: William Wragg wm.wragg@gmail.com