Support for refactored login token handling#1946
Merged
Conversation
loginToken handling is now done by the session loader, so we need to pass in the queryparams to MatrixChat. Also, MatrixChat no longer automatically reloads the page to drop the querystring, so we have to do that ourselves (doing it in index.js allows tokenlogin to be tested).
richvdh
added a commit
that referenced
this pull request
Aug 11, 2016
1. Check that localstorage is correctly updated on successful login (test for matrix-org/matrix-react-sdk#404) 2. Check that the saved HS isused for guest registration (test for matrix-org/matrix-react-sdk#405) 3. Test loginToken handling (test for matrix-org/matrix-react-sdk#406 / #1946)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loginToken handling is now done by the session loader, so we need to pass in
the queryparams to MatrixChat.
Also, MatrixChat no longer automatically reloads the page to drop the
querystring, so we have to do that ourselves (doing it in index.js allows
tokenlogin to be tested).
Corresponds to matrix-org/matrix-react-sdk#406.