Repository navigation
Wmwragg/room tag menu - #1941
Merged
Merged
Conversation
… do, but most of the mechanics are there now
…but need one manual ordering
…ional CSS tweaks to fit current design changes
…ack to 24px from 25px, as needs to be even number for the Text letter to align vertically
|
Can one of the admins verify this patch? |
Member
|
LGTM. One question for @antikewl - is it deliberate that this context menu has a white background whilst the others (mention config; per-message menu) is grey? |
|
Hi, yes, this is deliberate. The two grey menus are on white a background and the white menu is on a coloured background to give contrast. |
Contributor
Author
|
@ara4n I noticed that checks have failed, but they previously passed? I've checked here and all the tests still pass. |
Member
|
i think the failing tests (joining rooms over federation) may be because you haven't merged in develop recently enough. going to merge and see... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should close #1745. A companion branch matrix-org/matrix-react-sdk:wmwragg/room-tag-menu also needs to be merged.
Signed-off-by: William Wragg wm.wragg@gmail.com