Presentation for inline link#1799
Presentation for inline link#1799ara4n merged 2 commits intoelement-hq:developfrom ribot:feature-inline-link-preview
Conversation
|
Can one of the admins verify this patch? |
| display: block; | ||
| overflow-y: hidden; | ||
| overflow-x: hidden; | ||
| /*overflow-y: hidden; |
There was a problem hiding this comment.
This may become an issue, but it's the only way to hang elements out of the container.
There was a problem hiding this comment.
This was certainly an issue in the past, however, is it possible that overflow-x: visible is the right fix? (Bug #1154 was ugly scrollbar caused by overflow-x defaulting to scroll). We have to keep the overflow-y: hidden (unless you want to hang elements above/below the container for some reason?) in order to trap Zalgos, which are an amusingly common phenomenon in Matrix thanks to the early geeky audience. For instance, right now in #matrix-dev, this is the only thing stopping the top of SkaveRat's nick splurging all over Ralith:
| .mx_EventTile_content { | ||
| display: block; | ||
| overflow-y: hidden; | ||
| overflow-x: hidden; |
There was a problem hiding this comment.
don't we want overflow: visible; rather than the default auto here to avoid a repeat performance of #1154?
|
lgtm other than final question. i'll then merge it and unravel the mess with relying on |
|
going to merge this anyway and worry about the potential #1154 regression so I can fix the |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Fixed #1751, PR to
matrix-react-sdkto followSigned-off-by: Stefan Pearson stefan@ribot.co.uk