Skip to content

add settingDefaults to sample config#9919

Merged
bwindels merged 2 commits intodevelopfrom
bwindels/settings-config-doc
Oct 7, 2019
Merged

add settingDefaults to sample config#9919
bwindels merged 2 commits intodevelopfrom
bwindels/settings-config-doc

Conversation

@bwindels
Copy link
Copy Markdown
Contributor

@bwindels bwindels commented May 31, 2019

Copy link
Copy Markdown
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add to the docs for what this is, but otherwise looks fine to me. It's a bit awkward that it's empty - can we stick something like breadcrumbs into this?

@bwindels bwindels force-pushed the bwindels/settings-config-doc branch 2 times, most recently from 726e9f8 to 259ca06 Compare October 7, 2019 13:11
@bwindels
Copy link
Copy Markdown
Contributor Author

bwindels commented Oct 7, 2019

Would be nice to add to the docs for what this is, but otherwise looks fine to me. It's a bit awkward that it's empty - can we stick something like breadcrumbs into this?

Added breadcrumbs as example, and should already be documented at https://github.com/vector-im/riot-web/blob/develop/docs/config.md

@bwindels bwindels merged commit 57e597e into develop Oct 7, 2019
@turt2live
Copy link
Copy Markdown
Member

ah, so it is - thanks!

@t3chguy t3chguy deleted the bwindels/settings-config-doc branch May 12, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants