Conversation
b2874b5 to
363f14e
Compare
We're using BuildKite now
113528a to
f6d4c6a
Compare
Member
Author
|
This PR doesn't have status checks yet because for some reason BuildKite isn't sending them (or can't?) |
This was referenced Mar 14, 2019
8439b08 to
0d63181
Compare
1b856ec to
1fb8b23
Compare
e235b2c to
ef6313f
Compare
jryans
reviewed
Mar 15, 2019
Collaborator
jryans
left a comment
There was a problem hiding this comment.
Looking reasonable. I think my questions here have already been asked on the other repos, so I'll wait for those replies.
Nit: Buildkite seems to spell their name with lowercase "K".
Member
Author
Can I just disagree with their branding and continue using bad habits? (I'll go around fixing it) |
We should be giving the PR the best possible chance at passing the build.
jryans
approved these changes
Mar 15, 2019
Collaborator
jryans
left a comment
There was a problem hiding this comment.
Great, this one looks good to me! 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Better pipelines (see #9019)
Part of fixing #9164
Partnered with: