Allow Electron to zoom with CommandOrControl+=#8381
Allow Electron to zoom with CommandOrControl+=#8381jryans merged 2 commits intoelement-hq:developfrom
Conversation
Signed-off-by: Aaron Raimist <aaron@raim.ist>
jryans
left a comment
There was a problem hiding this comment.
I agree it's a bit sad that this is needed... Would it be a bit cleaner to listen for the other shortcut manually without a menu item?
|
I don't know a lot about Electron but it seems like you can't do this very well. I guess you can do
|
|
The other alternative is to get rid of the Shift+Command+Plus shortcut, the menu item will still look "wrong" but at least there will only be one |
|
I'd prefer to find a way to have only one menu item with ⌘+ displayed, while still accepting both Cmd-Plus and Cmd-Shift-Plus, as that's how most other native apps appear to handle this issue. Looking at Atom, that's what they seem to do, but of course their version is much more complex since they support user remappable shortcuts. It's a bit sad that this is so hard to solve with Electron... 😓 |
Maybe that's an okay compromise, since it seems unreasonably hard to do the right thing in Electron. I don't think anyone ever types Shift-Command-Plus anyway, so at least that would reflect reality. |
Signed-off-by: Aaron Raimist <aaron@raim.ist>
jryans
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me! 😁
…d in element-hq#8381) Signed-off-by: Aaron Raimist <aaron@raim.ist>
|
Use |
Fixes #7721
This creates two menu items which looks bad but setting the second one to
visible: falseseems to disable it too. 😡Hopefully someone will actually solve electron/electron#15496 upstream