Update chokidar to transitively get newer fsevents#7598
Merged
turt2live merged 1 commit intoelement-hq:developfrom Oct 25, 2018
Merged
Update chokidar to transitively get newer fsevents#7598turt2live merged 1 commit intoelement-hq:developfrom
turt2live merged 1 commit intoelement-hq:developfrom
Conversation
Signed-off-by: J. Ryan Stinnett <jryans@gmail.com>
turt2live
approved these changes
Oct 25, 2018
Member
turt2live
left a comment
There was a problem hiding this comment.
Thank you for the contribution! This doesn't explode on my machine and the tests pass, so it seems fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newer version of fsevents compiles successfully with Node 11, while the current version seems to fail during install.
This change does move chokidar to a new major version. The breaking change listed in the change log seems to only affect Windows-style paths, which don't apply here.
Signed-off-by: J. Ryan Stinnett jryans@gmail.com