Skip to content

Fix riot-web Promise.defer warnings (#7409)#7444

Merged
turt2live merged 5 commits intoelement-hq:developfrom
aaronraimist:promise-defer
Oct 9, 2018
Merged

Fix riot-web Promise.defer warnings (#7409)#7444
turt2live merged 5 commits intoelement-hq:developfrom
aaronraimist:promise-defer

Conversation

@aaronraimist
Copy link
Copy Markdown
Collaborator

@aaronraimist aaronraimist commented Oct 3, 2018 •
edited
Loading

More progress on #7409

@turt2live turt2live requested a review from a team October 3, 2018 03:01
bwindels
bwindels approved these changes Oct 4, 2018
View reviewed changes
Comment thread src/vector/platform/WebPlatform.js Outdated
Comment thread src/vector/platform/WebPlatform.js Outdated
Comment thread src/vector/index.js Outdated
Comment thread src/vector/getconfig.js Outdated
@bwindels
Copy link
Copy Markdown
Contributor

bwindels commented Oct 4, 2018 •
edited
Loading

Thanks! Have you done the Sign-Off already?

@dbkr
Copy link
Copy Markdown
Member

dbkr commented Oct 4, 2018

(DCO signoff is in the commit messages)

@aaronraimist
Fix Promise.defer warnings in getconfig.js (element-hq#7409)
a5fb33d 
Signed-off-by: Aaron Raimist <aaron@raim.ist>
@aaronraimist
Fix Promise.defer warnings in index.js (element-hq#7409)
54c46df 
Signed-off-by: Aaron Raimist <aaron@raim.ist>
@aaronraimist
Fix Promise.defer warnings in WebPlatform.js (element-hq#7409)
401c85a 
Signed-off-by: Aaron Raimist <aaron@raim.ist>
@aaronraimist
Fix lint warnings and turn warnings back on (element-hq#7409)
d035efb 
Signed-off-by: Aaron Raimist <aaron@raim.ist>
@aaronraimist
Undo turning warnings back on (element-hq#7409)
d836ad8 
I guess that turns on warnings for everything, not just riot-web

Signed-off-by: Aaron Raimist <aaron@raim.ist>
@aaronraimist
Copy link
Copy Markdown
Collaborator Author

aaronraimist commented Oct 9, 2018

This should be ready to go @bwindels

@turt2live turt2live merged commit 92db2b8 into element-hq:develop Oct 9, 2018
@turt2live
Copy link
Copy Markdown
Member

turt2live commented Oct 9, 2018

Thank you!

@dbkr dbkr mentioned this pull request Oct 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@turt2live turt2live turt2live approved these changes

+1 more reviewer

@bwindels bwindels bwindels approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aaronraimist @bwindels @dbkr @turt2live