Fix themeing bug with Firefox where "disabled" ignored#6301
Merged
lukebarnard1 merged 1 commit intodevelopfrom Mar 12, 2018
Merged
Fix themeing bug with Firefox where "disabled" ignored#6301lukebarnard1 merged 1 commit intodevelopfrom
lukebarnard1 merged 1 commit intodevelopfrom
Conversation
A bug in firefox means "disabled" isn't honoured when set in the HTML. Doing `a.disabled = false` does work however, and Chrome also appears to honour this.
Member
|
Is this to fix #6075 by chance? |
Contributor
Author
Yes :) |
Member
|
lgtm. @ara4n may want to take a look too |
Member
|
if it works on Chrome and Safari too, i'm happy. |
Contributor
Author
|
@dbkr reports this working in Safari |
Member
|
\o/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug in firefox means "disabled" isn't honoured when set in the
HTML. Doing
a.disabled = falsedoes work however, and Chromealso appears to honour this.
Fixes #6075