Fix crash; fs event received /w langauge file empty#6273
Merged
Conversation
It was common, at least for me, to experience a crash produced when running the `matrix-react-sdk/scripts/gen-i18n.js` script because when writing en_EN.json (via the script or otherwise) choikdar would receive an event and cause the file to be read, but the file would be empty when clearly it wasn't. This would happen even when doing an atomic write in gen-i18n. The fix adds a debounce as a workaround.
dbkr
approved these changes
Mar 5, 2018
Member
dbkr
left a comment
There was a problem hiding this comment.
Ew, but OK - only nicer way I can think of is catching the exception and re-scheduling the update (or use an editor that atomically renames the file into place...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was common, at least for me, to experience a crash produced
when running the
matrix-react-sdk/scripts/gen-i18n.jsscriptbecause when writing en_EN.json (via the script or otherwise)
choikdar would receive an event and cause the file to be read,
but the file would be empty when clearly it wasn't.
This would happen even when doing an atomic write in gen-i18n.
The fix adds a debounce as a workaround.