Make media dropdown wider#6245
Merged
ara4n merged 1 commit intoelement-hq:developfrom Feb 26, 2018
spantaleev:wider-media-dropdown
Merged
Make media dropdown wider#6245ara4n merged 1 commit intoelement-hq:developfrom spantaleev:wider-media-dropdown
ara4n merged 1 commit intoelement-hq:developfrom
spantaleev:wider-media-dropdown
Conversation
The media dropdown would sometimes contain options with long text, which can't possibly fit in 200px. (e.g. `Monitor of Built-in Audio Digital Stereo (HDMI)`) Dedicating some more space resolves the problem. Signed-off-by: Slavi Pantaleev <slavi@devture.com>
Member
|
awesome: thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The media dropdown would sometimes contain options
with long text, which can't possibly fit in 200px.
(e.g.
Monitor of Built-in Audio Digital Stereo (HDMI))Dedicating some more space resolves the problem.
This is somewhat of a continuation to #6244.
Before #6244, the options just overlap in a really ugly way.
After #6244 they span multiple lines, which is better, but still not perfect.
With this, it should hopefully be ideal.
Final result:
Signed-off-by: Slavi Pantaleev slavi@devture.com