Skip to content

Clarify that HTTPS is not just needed for VoIP#6146

Merged
turt2live merged 6 commits intoelement-hq:developfrom
rugk:patch-1
Sep 1, 2019
Merged

Clarify that HTTPS is not just needed for VoIP#6146
turt2live merged 6 commits intoelement-hq:developfrom
rugk:patch-1

Conversation

@rugk
Copy link
Copy Markdown
Contributor

@rugk rugk commented Feb 15, 2018

…but for basic security.

@MTRNord
Copy link
Copy Markdown
Contributor

MTRNord commented Feb 15, 2018

The pr should go against the develop branch.

@rugk rugk changed the base branch from master to develop February 15, 2018 12:15
Comment thread README.md
Comment thread README.md Outdated
Comment thread README.md Outdated
@jonathancross
Copy link
Copy Markdown

Ping @rugk still have a comment not responded to.

In addition to fixes from review, also add link to official source with more information.
@rugk
Copy link
Copy Markdown
Contributor Author

rugk commented Aug 27, 2019

Sorry, seems I've missed the notifications. 😄

Finally, improved/fixed.

@turt2live turt2live requested a review from a team August 27, 2019 20:48
Copy link
Copy Markdown
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rewording this

Comment thread README.md Outdated
@jryans
Copy link
Copy Markdown
Collaborator

jryans commented Aug 29, 2019

@rugk If you have time to apply the suggestion above or mark the PR so that maintainers can edit and do so, then I believe we can press the merge button after that. 😁

Co-Authored-By: Travis Ralston <travpc@gmail.com>
@rugk
Copy link
Copy Markdown
Contributor Author

rugk commented Sep 1, 2019

Done. FYI "Allow edits from maintainers." had already been aliowed/selected.

@turt2live
Copy link
Copy Markdown
Member

for some reason it was blocking me from doing both in and out of github :(

Thanks!

@turt2live turt2live merged commit f97b632 into element-hq:develop Sep 1, 2019
@rugk rugk deleted the patch-1 branch September 2, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants