Conversation
Contributor
rxl881
commented
Nov 10, 2017
- Vertically align widget title bar text and icons.
- Add white on dark edit icon
- Add yellow warning triangle icon
…rxl881/visualCue
Member
|
looks plausible to me, although the tests are breaking, which is probably my fault... |
Member
|
ah, yup, broken tests is because it's testing it against an old version of matrix-react-sdk, i think |
Contributor
Author
|
Thanks. Yep, I am pretty sure that the test failures are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.