Skip to content

Add CSS for CreateGroupDialog to give group ID input suffix and prefix style#5505

Merged
lukebarnard1 merged 2 commits intodevelopfrom
luke/groups-add-style-to-create-group-dialog
Nov 3, 2017
Merged

Add CSS for CreateGroupDialog to give group ID input suffix and prefix style#5505
lukebarnard1 merged 2 commits intodevelopfrom
luke/groups-add-style-to-create-group-dialog

Conversation

@lukebarnard1
Copy link
Copy Markdown
Contributor

@lukebarnard1 lukebarnard1 commented Nov 3, 2017

2017-11-03-154127_652x231_scrot

background-color: $primary-bg-color;
}

.mx_CreateGroupDialog_input.has_prefix.has_suffix {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to namespace CSS classes correctly, otherwise this will collide with any other random CSS dependency (e.g. markdown, syntax highlighter, etc) which might choose to define a generic class like has_prefix. In this instance, I assume it should be something like mx_CreateGroupDialog_input_hasPrefix.

....however, it's very very unclear and confusing as to what the difference is between mx_CreateGroupDialog_input_prefix and mx_CreateGroupDialog_input.has_prefix here, and so i suspect you need a better name anyway.

Copy link
Copy Markdown
Contributor Author

@lukebarnard1 lukebarnard1 Nov 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I see what you're saying

let's go with
.mx_CreateGroupDialog_prefix and .mx_CreateGroupDialog_input_hasPrefixAndSuffix

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, i would avoid the .foo.bar.baz selector format - we don't use it in many other places, and instead do the (different) .foo .bar, .foo .baz selector to say "select classes with name bar or baz which are within a parent class called foo". (Unless there's a performance improvement I've forgotten about explicitly having .foo.bar.baz being "select classes which have names foo, bar & baz"? I may also be a bit historically traumatised by .foo.bar.baz not working reliably on IE4 ;P)

@ara4n
Copy link
Copy Markdown
Member

ara4n commented Nov 3, 2017

lgtm

@lukebarnard1 lukebarnard1 merged commit 5d9a1b4 into develop Nov 3, 2017
@t3chguy t3chguy deleted the luke/groups-add-style-to-create-group-dialog branch May 12, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants