Add back bottom border to widget title bar#5458
Merged
Conversation
dbkr
reviewed
Oct 31, 2017
Member
dbkr
left a comment
There was a problem hiding this comment.
lgtm, although I'm surprised by the package-lock.json update - surely a small CSS change shouldn't be accompanied by a sizeable package-lock.json update?
Contributor
Author
|
Regarding package-lock.json... yeah, am happy to remove that (in fact I will). However, it would be good to know what the rule is (that we are going to use), for when package-lock.json should be included, and when it shouldn't. @dbkr Any suggestions for a good rule of thumb? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is especially noticeable / needed when widget content is loading, or there is an error (as there is no separator between the widget title content and the main body).