Conversation
and make the default config*.sjon so we'll automatically symlink any config files in the current dir.
because that's really all it's doing and we can use it for other things
Because redeploy.py already has a 'symlink' option that does something else.
richvdh
reviewed
Sep 20, 2017
| for include in args.include: | ||
| deployer.symlink_paths.update({ os.path.basename(pth): pth for pth in glob.iglob(include) }) | ||
|
|
||
| print("%r", (deployer.symlink_paths,)) |
Member
There was a problem hiding this comment.
this looks like leftover debug?
| deployer.should_clean = args.clean | ||
| deployer.config_locations = dict(args.configs) if args.configs else {} | ||
|
|
||
| deployer.symlink_paths = {} |
richvdh
reviewed
Sep 20, 2017
| "config.json": args.config, | ||
| } | ||
|
|
||
| deployer.symlink_paths = {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So by default it will symlink all config files in the current dir
Builds on #5089(easier to just keep everything in this PR)