Avoid re-rendering RoomList on room switch#5015
Merged
Conversation
ara4n
reviewed
Sep 11, 2017
| }, | ||
| shouldComponentUpdate: function(nextProps, nextState) { | ||
| // MatrixChat will update whenever the user switches | ||
| // rooms, but propagating this chnage all the way down |
ara4n
reviewed
Sep 11, 2017
| // here. The RoomTiles listen for the room change | ||
| // events themselves to know when to update. | ||
| // We just need to update if any of these things change. | ||
| if ( |
Member
There was a problem hiding this comment.
might want an XXX to spell out that if we add new props, we have to update the shouldComponentUpdate (either here or in the props definition)
Member
|
lgtm, modulo minor niggles |
if adding new props
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See matrix-org/matrix-react-sdk#1375