Skip to content

generic contextual menu for tooltip/responses#4989

Merged
dbkr merged 3 commits intodevelopfrom
t3chguy/on_copy_tooltip
Sep 13, 2017
Merged

generic contextual menu for tooltip/responses#4989
dbkr merged 3 commits intodevelopfrom
t3chguy/on_copy_tooltip

Conversation

@t3chguy
Copy link
Copy Markdown
Member

@t3chguy t3chguy commented Sep 6, 2017

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@@ -0,0 +1,29 @@
/*
Copyright 2015, 2016 OpenMarket Ltd
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inb4 licensing

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, shows my copy pasta

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

'use strict';

import React, {PropTypes} from 'react';
Copy link
Copy Markdown
Member

@dbkr dbkr Sep 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move to using import PropTypes from 'prop-types' in new code.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC I tried but it wasn't installed

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@dbkr dbkr merged commit f148844 into develop Sep 13, 2017
@t3chguy t3chguy deleted the t3chguy/on_copy_tooltip branch October 29, 2017 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants