Skip to content

Fix overflowing login/register buttons on some languages issue #4804#4858

Merged
lukebarnard1 merged 3 commits intoelement-hq:developfrom
Nostradamos:fix-4804
Aug 31, 2017
Merged

Fix overflowing login/register buttons on some languages issue #4804#4858
lukebarnard1 merged 3 commits intoelement-hq:developfrom
Nostradamos:fix-4804

Conversation

@Nostradamos
Copy link
Copy Markdown

@Nostradamos Nostradamos commented Aug 23, 2017 •
edited
Loading

For some languages the register and/or login buttons are to small, which causes the text to overflow. With this fix the buttons expand to fit the text content and if needed wrap to two lines if both buttons can't fit into one line. Issue: #4804
image

image

Signed-off-by: Lion Marlon n0stradamos@mail.ru

@Nostradamos Nostradamos changed the base branch from master to develop August 23, 2017 20:35
@ara4n
Copy link
Copy Markdown
Member

ara4n commented Aug 23, 2017

this looks good - thanks :) the only change I'd suggest would be to put some padding (~5px) within the button, so that the text doesn't go too close to the edge.

@Nostradamos
Copy link
Copy Markdown
Author

Nostradamos commented Aug 24, 2017

Thanks for reviewing and replying this fast.
Because it's a button, it already has a padding from 6px.
And in my opinion the text doesn't get too close to the edge,
but if you want me to increase it even more, this is of course
no problem.
http://i.imgur.com/EhHhP5e.png

@lukebarnard1
Copy link
Copy Markdown
Contributor

lukebarnard1 commented Aug 30, 2017

if you want me to increase it even more, this is of course no problem.

I think this is what @ara4n is asking for. Stick padding: 0px 11px; in there for those buttons.

We should also have word-break: break-word; in there too to fix your overflowing issue.

@lukebarnard1
Copy link
Copy Markdown
Contributor

lukebarnard1 commented Aug 31, 2017

Oh. @Nostradamos, I failed to see that you had already added padding and if I had I would have only asked for the word-break. Anyway, if you can excuse my incompetence, LGTM 😀

@lukebarnard1 lukebarnard1 merged commit da9dcc8 into element-hq:develop Aug 31, 2017
@Nostradamos
Copy link
Copy Markdown
Author

Nostradamos commented Aug 31, 2017

@lukebarnard1 no problem, thanks for merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lukebarnard1 lukebarnard1 lukebarnard1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Nostradamos Nostradamos

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nostradamos @ara4n @lukebarnard1