Skip to content

CSS for group edit UI#4608

Merged
dbkr merged 8 commits intodevelopfrom
dbkr/groupview_edit
Jul 25, 2017
Merged

CSS for group edit UI#4608
dbkr merged 8 commits intodevelopfrom
dbkr/groupview_edit

Conversation

@dbkr
Copy link
Copy Markdown
Member

@dbkr dbkr commented Jul 17, 2017

Adds CSS for the edit mode of GroupView

@lukebarnard1
Copy link
Copy Markdown
Contributor

I shall wait until we're happy with matrix-org/matrix-react-sdk#1229 before reviewing

Copy link
Copy Markdown
Contributor

@lukebarnard1 lukebarnard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

font-size: 22px;
padding-left: 19px;
padding-right: 16px;
/* why isn't text-overflow working? */
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You actually need a bunch of things for this to ever work:

 overflow: hidden;
 white-space: nowrap;
 text-overflow: ellipsis;

@lukebarnard1 lukebarnard1 assigned dbkr and unassigned lukebarnard1 Jul 25, 2017
@dbkr dbkr merged commit ec6efd2 into develop Jul 25, 2017
@t3chguy t3chguy deleted the dbkr/groupview_edit branch May 12, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants