Make some adjustments to mx_UserPill and mx_RoomPill#4597
Merged
lukebarnard1 merged 2 commits intodevelopfrom Jul 19, 2017
Merged
Make some adjustments to mx_UserPill and mx_RoomPill#4597lukebarnard1 merged 2 commits intodevelopfrom
lukebarnard1 merged 2 commits intodevelopfrom
Conversation
So that they can appear correctly in the body of a text message.
lukebarnard1
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jul 17, 2017
dbkr
approved these changes
Jul 17, 2017
Contributor
Author
|
I'm going to have to change this so that it matches the design - user pills should not have a background colour in the timeline. |
Member
|
yep, seems reasonable |
Contributor
Author
|
Given this is just a CSS change, I'm assuming the failing react-sdk test is unrelated (https://travis-ci.org/vector-im/riot-web/jobs/255197083 <-- @richvdh) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that they can appear correctly in the body of a text message.