Kieran gould/12hourtimestamp#3961
Conversation
| .mx_EventTile_selected .mx_EventTile_line { | ||
| border-left: $accent-color 5px solid; | ||
| padding-left: 60px; | ||
| padding-left: 100px; |
There was a problem hiding this comment.
please let's not change the whole layout of the app just to provide the option of 12h timestamps ;)
See comments of https://github.com/matrix-org/matrix-react-sdk/pull/903/files#r117365391
| { DateUtils.formatTime(date) } | ||
| </span> | ||
| ); | ||
| if (UserSettingsStore.getSyncedSetting('showTwelveHourTimestamps')) { |
There was a problem hiding this comment.
technically the state of render() should depend only on props & state rather than js-sdk state, but i'm happy to ignore this for now :)
| </span> | ||
| ); | ||
| } | ||
| else { |
There was a problem hiding this comment.
else should be on previous line for readability :)
| </span> | ||
| ); | ||
| if (UserSettingsStore.getSyncedSetting('showTwelveHourTimestamps')) { | ||
| return ( |
There was a problem hiding this comment.
indentation should be 4 spaces pleaseeeee
| .mx_FilePanel .mx_EventTile_selected .mx_EventTile_line { | ||
| padding-left: 0px; | ||
| } | ||
|
|
There was a problem hiding this comment.
probably not worth messing up latest commit on this file for this
| } | ||
|
|
||
| .mx_EventTile_e2eIcon_12hr { | ||
| padding-left: 5px; |
|
this lgtm other than concerns on the react-sdk one (including how to structure the CSS) |
3343de7 to
cae62c8
Compare
|
lgtm having fixed typo, i think |
Linked to: matrix-org/matrix-react-sdk#903