Conversation
Just copy-and-paste the updated version from js-sdk in here.
attempt to make the logging a bit more comprehensible
give the client a bit longer to get started.
lukebarnard1
approved these changes
May 18, 2017
Contributor
lukebarnard1
left a comment
There was a problem hiding this comment.
LGTM apart from tiny thing
| if (idx >= 0) { | ||
| console.log("Aborting HTTP request: %s %s", opts.method, opts.uri); | ||
| console.log("Aborting HTTP request: %s %s", opts.method, | ||
| opts.uri); |
Contributor
There was a problem hiding this comment.
This doesn't seem necessary unless it was to reduce line length?
Member
Author
There was a problem hiding this comment.
oh, it just came with the c&p from js-sdk. Where it probably did happen to reduce line length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give the client a bit longer to get started.
I also pulled in some mock-request updates from js-sdk, and did a few more updates (which I'll probably backport), though none of that turned out to be strictly necessary.