Conversation
DRY: moved Favicon stuff into the base platform Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Member
|
someone was just asking for this in HQ... @dbkr, feel free to reassign this if you don't have PR review bandwidth |
|
Hey @t3chguy can you make the notification count badge showing also in Windows taskbar icon like this?:
|
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Member
Author
|
@SiwyPL spróbuję |
LETS MAKE IT CLEAR WE ARE NEEDY AND WANT ATTENTION Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
also improve favicon updating to not change if we're same as previous not sure how intensive the nativeImage stuff is but cheap efficiency For FLASH FLASH I moved the setBadgeCount stuff RPC -> IPC should be more reliable now, its in electron-main Win only: if mainWindow is set and is not in focus make it FLASH clear flash if notification gets cleared elsewhere debounce focus handler so we don't set a million of them if the app is backgrounded a while Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Member
Author
|
@SiwyPL now it'll both flash and show you number of notifications, you wanted it to be obvious right :P? |
|
oh maaan thanks, that was quick |
dbkr
approved these changes
May 19, 2017
Member
dbkr
left a comment
There was a problem hiding this comment.
This looks super awesome, thanks! Sorry for not getting to review this sooner.
Member
Author
|
No worries @dbkr - clear how busy you've been recently :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes #3835
thus for #3554
make Electron Tray icon mimic the Favicon (has notifications count badge)
make Electron Tray Tooltip mimic document.title (has info like [offline])
add electron_app to .gitignore, missed it when renaming
tidy up tray.js
move Favico.js stuff into VectorBasePlatform as now Electron uses it too, no point doing the generation in the other process as that just means the electron package will have two copies of the library.
Screenshots below shows favicon still working on WebPlatform, and the tray icon behaviour too:
