Skip to content

move electron -> electron_app because npm smart#3877

Merged
dbkr merged 1 commit intodevelopfrom
t3chguy/electron_install_fix
May 10, 2017
Merged

move electron -> electron_app because npm smart#3877
dbkr merged 1 commit intodevelopfrom
t3chguy/electron_install_fix

Conversation

@t3chguy
Copy link
Copy Markdown
Member

@t3chguy t3chguy commented May 10, 2017

npm is "smart" enough to try and install our electron wrapper as a module
instead of the actual electron package. With no way to ignore directories.
I'd like to think of this as temporary, until I get to rip apart riot-web
and riot-electron

$ npm i electron
npm ERR! Refusing to install package with name "riot-web" under a package
npm ERR! also called "riot-web". Did you name your project the same
npm ERR! as the dependency you're installing?

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

…dule

instead of the actual electron package. With no way to ignore directories.
I'd like to think of this as temporary, until I get to rip apart riot-web
and riot-electron

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@dbkr dbkr merged commit e67e891 into develop May 10, 2017
@t3chguy t3chguy deleted the t3chguy/electron_install_fix branch May 11, 2017 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants