Remove leading v in /version file, for SemVer and to match Electron ver#3683
Merged
dbkr merged 2 commits intoelement-hq:developfrom May 5, 2017
t3chguy:t3chguy/electron_version_inconsistency
Merged
Remove leading v in /version file, for SemVer and to match Electron ver#3683dbkr merged 2 commits intoelement-hq:developfrom t3chguy:t3chguy/electron_version_inconsistency
dbkr merged 2 commits intoelement-hq:developfrom
t3chguy:t3chguy/electron_version_inconsistency
Conversation
Member
|
is there any chance that this breaks package.sh on electron? #3682 implies that there's some kind of link - and so we change the behaviour on riot-web without changing package.sh, i'm assuming bad stuff may happen? |
Member
|
I don't think so, although I'd prefer the other fix to be honest, ie. make getAppVersion() impls return semver compliant version strings and sort out in the package script where we're specifying the version (a semver string) and the tag ('v'). |
and also then consistent with electron versioning Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Member
Author
|
@dbkr PTAL (closed and reopened to trigger a rebuild) |
dbkr
approved these changes
May 5, 2017
Member
dbkr
left a comment
There was a problem hiding this comment.
Yeah, I think this makes our version strings a bit more consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3682