Skip to content

Set padding-bottom: 0px for .mx_Dialog spinner#3351

Merged
lukebarnard1 merged 2 commits intodevelopfrom
luke/css-spinner-height
Mar 3, 2017
Merged

Set padding-bottom: 0px for .mx_Dialog spinner#3351
lukebarnard1 merged 2 commits intodevelopfrom
luke/css-spinner-height

Conversation

@lukebarnard1
Copy link
Copy Markdown
Contributor

This was causing #3226

@ara4n
Copy link
Copy Markdown
Member

ara4n commented Mar 3, 2017

it seems very strange it was ever special-casing the left edge. why wouldn't this be padding: 0px?

@ara4n ara4n assigned lukebarnard1 and unassigned ara4n Mar 3, 2017
@lukebarnard1
Copy link
Copy Markdown
Contributor Author

lukebarnard1 commented Mar 3, 2017

@ara4n padding: 0px would make far more sense, and works in practice. Strange indeed!

@lukebarnard1 lukebarnard1 assigned ara4n and unassigned lukebarnard1 Mar 3, 2017
@ara4n
Copy link
Copy Markdown
Member

ara4n commented Mar 3, 2017

lgtm!

@lukebarnard1 lukebarnard1 merged commit b1f14ba into develop Mar 3, 2017
@t3chguy t3chguy deleted the luke/css-spinner-height branch May 12, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants