Fix broken tests caused by adding IndexedDB support#3242
Merged
Conversation
This test assumed that `/sync` would be called immediately after rendering `<MatrixChat />` but this isn't true in an IndexedDB world: it bounces via `store.startup()` first. It looks like the tests resolve this by adding `q.delay(1)` so that's what I've done: in the future it would be better to extend `HttpBackend` to have a `waitFor(req) Promise` function so we can removing timing from the tests.
richvdh
approved these changes
Feb 17, 2017
Member
richvdh
left a comment
There was a problem hiding this comment.
in the future it would be better to extend HttpBackend to have
a waitFor(req) Promise function so we can removing timing from the tests.
yup, fully agreed. If this fixes the tests, I'm happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test assumed that
/syncwould be called immediately after rendering<MatrixChat />but this isn't true in an IndexedDB world: it bounces viastore.startup()first.It looks like the tests resolve this by adding
q.delay(1)so that's whatI've done: in the future it would be better to extend
HttpBackendto havea
waitFor(req) Promisefunction so we can removing timing from the tests.