Merged
Conversation
Do `npm install` on js-sdk rather than `npm run build`, which will hopefully mean that `browserify` gets installed before we try to run it. The README says we should use `npm install` for the react-sdk too, so let's do that, and bring the travis and jenkins builds into sync with the README.
dbkr
approved these changes
Feb 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do
npm installon js-sdk rather thannpm run build, which will hopefullymean that
browserifygets installed before we try to run it.The README says we should use
npm installfor the react-sdk too, so let's dothat, and bring the travis and jenkins builds into sync with the README.