Include current version in update check explicitly#2967
Merged
Conversation
Hopefully fix #2847
richvdh
reviewed
Jan 17, 2017
Member
richvdh
left a comment
There was a problem hiding this comment.
So what's this for? are you planning on something server-side which will make use of this?
Anyway, LGTM modulo stupid questions.
| // it anywhere (apart from the User-Agent) so it's up to us. We could | ||
| // (and previously did) just use the User-Agent, but this doesn't | ||
| // rely on NSURLConnection setting the User-Agent to what we expect, | ||
| // and also acts as a convenient cache-buster between versions. |
Member
There was a problem hiding this comment.
surely a cache-buster which depends on the current local version doesn't help?
Member
Author
There was a problem hiding this comment.
Yeah, was trying to say that it would make sure a new version of the app did a new hit. Have clarified the comment.
Member
Author
|
Yep, currently it uses the value in the User-Agent so I'll migrate it over to use this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fix #2847