Skip to content

Fix broken tests#2730

Merged
richvdh merged 1 commit intodevelopfrom
dbkr/fix_test_breakage
Dec 9, 2016
Merged

Fix broken tests#2730
richvdh merged 1 commit intodevelopfrom
dbkr/fix_test_breakage

Conversation

@dbkr
Copy link
Copy Markdown
Member

@dbkr dbkr commented Dec 9, 2016

Promises are now not being resolved within the same tick, so give
another tick for the UI to update after all the HTTP calls have
flushed through. This is fairly terrible, but I can't immediately
see a better way of doing this.

Promises are now not being resolved within the same tick, so give
another tick for the UI to update after all the HTTP calls have
flushed through. This is fairly terrible, but I can't immediately
see a better way of doing this.
@richvdh
Copy link
Copy Markdown
Member

richvdh commented Dec 9, 2016

Ick, but ok.

Ftr you can just do .delay(1) instead of .then(function() { return q.delay(1); })

@richvdh richvdh merged commit 8097b15 into develop Dec 9, 2016
@dbkr dbkr deleted the dbkr/fix_test_breakage branch December 14, 2016 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants