Quick and dirty support for custom welcome pages.#2575
Merged
Conversation
dbkr
reviewed
Nov 14, 2016
| console.log(error); | ||
| this.setState({ page: "Couldn't load home page" }); | ||
| } | ||
| ).then( |
| componentWillMount: function() { | ||
| fetch(this.props.config.home_page).then( | ||
| (response)=>{ | ||
| return response.text(); |
Member
There was a problem hiding this comment.
NB. that this could be an error response from the server, although arguably it makes about as much sense to display the error page from the server as our own error message.
Contributor
There was a problem hiding this comment.
This could default to some default message, "Sorry, your welcome page could not be loaded"?
| Riot is built on <a href="https://matrix.org">Matrix</a> - a new open protocol for interoperable and secure decentralised communication. | ||
| <br/> | ||
| To learn more, head over to <a href="https://matrix.org">Matrix.org</a> - and to better understand Riot, check out the official <a href="https://riot.im">Riot Website</a>. | ||
| </p> |
Member
There was a problem hiding this comment.
It would be nice if this could be versioned somewhere else rather than living with the rest of the vector source (especially in the root dir). Ditto for the images.
Contributor
There was a problem hiding this comment.
It shall be kept on the RTS, so that solves that!
This was referenced Jan 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.