Fix mstile-310x150 by renaming it#14485
Merged
jryans merged 2 commits intoelement-hq:developfrom Jul 15, 2020
jaller94:j94/fix-mstile-310-150
Merged
Fix mstile-310x150 by renaming it#14485jryans merged 2 commits intoelement-hq:developfrom jaller94:j94/fix-mstile-310-150
jryans merged 2 commits intoelement-hq:developfrom
jaller94:j94/fix-mstile-310-150
Conversation
t3chguy
requested changes
Jul 15, 2020
Member
t3chguy
left a comment
There was a problem hiding this comment.
This is 100% backwards, the actual size is not 310;
Contributor
Author
|
310x150 is correct. The wide tile spans two tiles (2 * 150px) plus the gap that would be in between. https://docs.microsoft.com/en-us/uwp/schemas/appxpackage/appxmanifestschema2013/element-defaulttile Yes, the image should be 310x150. |
Member
|
Be that as it may, the actual image is 300x150 so needs re-exporting, surely? |
refi64
added a commit
to refi64/riot-web-lc
that referenced
this pull request
Jul 17, 2020
[Full Changelog](element-hq/element-web@v1.7.0...v1.7.1) * Upgrade to React SDK 2.10.1 * Fix SSO session ID paramater [\element-hq#14544](element-hq#14544) * Run pngcrush on vector-icons [\element-hq#14488](element-hq#14488) * Fix hosting signup link [\element-hq#14502](element-hq#14502) * Use the right protocol for SSO URLs [\element-hq#14513](element-hq#14513) * Fix mstile-310x150 by renaming it [\element-hq#14485](element-hq#14485) * Update blog and twitter links to point to Element [\element-hq#14478](element-hq#14478)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mstile-310x150.png has the wrong name.
This changes the filename to match the config that refers to it:
https://github.com/vector-im/riot-web/blob/7c17272c838e8971cdfe63a101d1be594b37cd39/res/vector-icons/browserconfig.xml#L8