Merged
Conversation
jryans
reviewed
May 4, 2020
|
|
||
| let og_image_url = process.env.RIOT_OG_IMAGE_URL; | ||
| if (!og_image_url) og_image_url = 'https://riot.im/app/themes/riot/img/logos/riot-im-logo-black-text.png'; | ||
| if (!og_image_url) og_image_url = 'https://about.riot.im/images/opengraph.png'; |
Collaborator
There was a problem hiding this comment.
Perhaps it's better to keep the app self-contained by copying this asset into the logos folder? If we redesign about.riot.im some day, we're likely to forget we've depended on this path.
jryans
approved these changes
May 7, 2020
Collaborator
jryans
left a comment
There was a problem hiding this comment.
Great, looks good to me! 😁
Member
|
worth noting https://riot.im/app/themes/riot/img/logos/opengraph.png is 404ing |
Collaborator
Right, it normally wouldn't have appeared until release. I went ahead and manually copied it from develop to app, so should be good now. |
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #12014
replaces: #13461