Add riot-desktop shortcuts for forward/back matching browsers&slack#13133
Add riot-desktop shortcuts for forward/back matching browsers&slack#13133
Conversation
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
thank you 👍 |
dbkr
left a comment
There was a problem hiding this comment.
NB. windows has the concept of a 'back' sat the system level for keyboards/mics with dedicated 'back' buttons, which electron represents through app-command (https://www.electronjs.org/docs/api/browser-window#event-app-command-windows-linux) - we should probably wire this up too if electron doesn't do it automatically.
More frustratingly, macos doesn't have a system level conecpt of 'back', but it does have the three-finger swipe gestures. We should probably also support these. To make things more complex, cmd+left/right also work as back/forward in chrome on Mac (and indeed is what I use). Unsure if we want to support this to be consistent with chrome.
Also also does this need a riot-desktop PR?
|
I already wired that app-command years ago. (and I use it LOADS) Yup I will port to riot-desktop also |
Hmm, but aren't cmd + left/right used for text field jumping between words?
|
|
So it seems like it may be an unpopular shortcut https://superuser.com/questions/1367750/how-to-prevent-command-arrow-keys-from-navigating-macos-chrome-forward-backward |
dbkr
left a comment
There was a problem hiding this comment.
oh, then awesome. And yeah, I guess that shortcut is a bit weird in that it does different things depending on whether you're in a text box or not. lgtm then.
Fixes #12920
Requires matrix-org/matrix-react-sdk#4392
Requires element-hq/element-desktop#68
Matches browser default shortcuts for forward/back and also Slack