App load order tweaks for code splitting#13032
Merged
Conversation
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
…ove mobile_guide redirect to index.ts Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Member
Author
|
Code Splitting seems to have a reasonable performance improvement, the majority of future improvements will come from parallelizing loading where possible. Chrome performance test results (5 rounds, ms) |
bwindels
approved these changes
Apr 6, 2020
Contributor
bwindels
left a comment
There was a problem hiding this comment.
Generally looks good, just a question about the webpack annotations.
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Member
Author
|
Actually this ended up confusing webpack and creating a 20kB overhead so reverting and merging at the state it was previously approved in. |
This reverts commit e788433 Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
bwindels
approved these changes
Apr 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-react-sdk#4343
No bundle size change, but much better split.
the bundle circled in red is the entrypoint
bundle.js(just 27.81kb) which means that our modernizr self check can be done much quicker while the other key bundles preload and also much less possibly incompatible code is executed.The largest bundle here,
vendors~init.js(4.99mb) is also the most cachable as it consists of majority of thenode_modulesof the 3 layers.Phase 2 of ~4 towards the multitude of app load related issues. This has only has one functional change for incompatible browser handling, the mobile_guide check&redirect is done in the
index.tswhich is the safest part of the app, using the least advanced features.the
node_moduleshere is just thequerystringlibrary necessary for part of the mobile_guide redirect check.