Conversation
Collaborator
Author
|
Since I'd like everyone on the team to be aware and provide feedback if they have some, I'll try requesting review from everyone involved. |
t3chguy
approved these changes
Mar 13, 2020
Member
|
@jryans this needs rebasing on develop |
This documents various attributes of our overall review policy from code, design, and product perspectives. Fixes #12614
43f6554 to
d930d14
Compare
Collaborator
Author
|
Updated, hopefully should pass CI now. |
turt2live
approved these changes
Mar 13, 2020
Member
|
(we should be avoiding force pushes 😛 - a merge commit for develop -> feature branch is fine) |
Co-Authored-By: Travis Ralston <travpc@gmail.com>
Collaborator
Author
|
Haha, indeed I should re-read and apply the doc to my own thoughts as well 😅 |
turt2live
reviewed
Mar 13, 2020
dbkr
approved these changes
Mar 13, 2020
bwindels
approved these changes
Mar 16, 2020
Contributor
bwindels
left a comment
There was a problem hiding this comment.
One question, otherwise lgtm, good to have these!
foldleft
approved these changes
Mar 16, 2020
uhoreg
approved these changes
Mar 16, 2020
Member
uhoreg
left a comment
There was a problem hiding this comment.
aside from comments left by others, lgtm
Co-Authored-By: Travis Ralston <travpc@gmail.com>
t3chguy
pushed a commit
that referenced
this pull request
Oct 17, 2024
Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This documents various attributes of our overall review policy from code,
design, and product perspectives.
Rendered
Fixes #12614