Skip to content

Update from Weblate#12480

Merged
dbkr merged 3 commits intoelement-hq:developfrom
RiotTranslateBot:weblate-riot-web-riot-web
Feb 24, 2020
Merged

Update from Weblate#12480
dbkr merged 3 commits intoelement-hq:developfrom
RiotTranslateBot:weblate-riot-web-riot-web

Conversation

@RiotTranslateBot
Copy link
Copy Markdown
Contributor

No description provided.

jakobrs and others added 3 commits February 20, 2020 21:24
Currently translated at 91.3% (21 of 23 strings)

Translation: Riot Web/riot-web
Translate-URL: https://translate.riot.im/projects/riot-web/riot-web/nb_NO/
Currently translated at 100.0% (23 of 23 strings)

Translation: Riot Web/riot-web
Translate-URL: https://translate.riot.im/projects/riot-web/riot-web/hu/
@dbkr dbkr merged commit e3cbcc8 into element-hq:develop Feb 24, 2020
t3chguy pushed a commit that referenced this pull request Oct 17, 2024
* Convert tabbedview to functional component

The 'Tab' is still a class, so now it's a functional component that
has a supporting class, which is maybe a bit... jarring, but I think
is actually perfectly logical.

* put comment back

* Fix bad tab ID behaviour

* Make TabbedView a controlled component

This does mean the logic of keeping what tab is active is now in each
container component, but for a functional component, this is a single
line. It makes TabbedView simpler and the container components always
know exactly what tab is being displayed rather than having to effectively
keep the state separately themselves if they wanted it.

Based on matrix-org/matrix-react-sdk#12478

* Fix some types & unused prop

* Remove weird behaviour of using first tab is active isn't valid

* Don't pass initialTabID here now it no longer has the prop

* Fix test

* bleh... id, not icon

* Change to sub-components

and use contitional call syntax

* Comments

* Fix element IDs

* Fix merge

* Test DesktopCapturerSourcePicker

to make sonarcloud the right colour

* Use custom hook for the fllback tab behaviour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants