Skip to content

BuildKite: Only deploy to /develop if everything else passed#11996

Merged
t3chguy merged 1 commit intodevelopfrom
t3chguy/buildkite
Jan 22, 2020
Merged

BuildKite: Only deploy to /develop if everything else passed#11996
t3chguy merged 1 commit intodevelopfrom
t3chguy/buildkite

Conversation

@t3chguy
Copy link
Copy Markdown
Member

@t3chguy t3chguy commented Jan 22, 2020

Fixes #11866

Described as an implicit dependency to simplify adding more stages later

@t3chguy t3chguy requested a review from a team January 22, 2020 15:06
Copy link
Copy Markdown
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good enough for now

@t3chguy
Copy link
Copy Markdown
Member Author

t3chguy commented Jan 22, 2020

good enough for now

Whats the ideal fix here?

@t3chguy t3chguy merged commit 8d769da into develop Jan 22, 2020
@t3chguy t3chguy deleted the t3chguy/buildkite branch May 12, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

We deploy to /develop even when the tests fail

2 participants