Skip to content

Fix indentation on webpack config and make sourcemapped files legible#11892

Merged
turt2live merged 3 commits intodevelopfrom
travis/fix-sourcemaps
Jan 16, 2020
Merged

Fix indentation on webpack config and make sourcemapped files legible#11892
turt2live merged 3 commits intodevelopfrom
travis/fix-sourcemaps

Conversation

@turt2live
Copy link
Copy Markdown
Member

See commits for individual parts.

@turt2live turt2live requested a review from a team January 16, 2020 18:48
Copy link
Copy Markdown
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason we didn't switch to eval-source-map before was because it generally caused webpack to run out of memory or the box to die of swapping on linux - with any luck that's been fixed in newer webpack...

@turt2live
Copy link
Copy Markdown
Member Author

yea, let's see if not using it for production is good enough for the CI.

@dbkr
Copy link
Copy Markdown
Member

dbkr commented Jan 16, 2020

re-lgtm. we'll find out tomorrow if it works for dev on Linux...

@turt2live turt2live merged commit 9a084a6 into develop Jan 16, 2020
@turt2live turt2live deleted the travis/fix-sourcemaps branch January 16, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants