Don't minifiy builds of develop through CI packaging#11867
Merged
Don't minifiy builds of develop through CI packaging#11867
Conversation
Fixes #11864 This uses an environment variable because the build script assumes you want a production build, but we don't for this particular script. To avoid having a mess of NPM scripts to worry about, we'll just pass a flag down.
turt2live
commented
Jan 15, 2020
Contributor
|
I'm okay with this, but it looks like @dbkr already took a look so I'll leave it to him |
dbkr
approved these changes
Jan 16, 2020
Member
dbkr
left a comment
There was a problem hiding this comment.
Fwiw this is a reason we had build:dev etc. (it also meant that you could build a bundle on disk, eg. for electron dev, without having to wait for it to minify it or running webpack manually).
Collaborator
|
I am also sad about |
Member
Author
|
the trouble with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11864
This uses an environment variable because the build script assumes you want a production build, but we don't for this particular script. To avoid having a mess of NPM scripts to worry about, we'll just pass a flag down.