Remove mention of vector.im as default identity server on mobile guide#11544
Merged
turt2live merged 1 commit intoelement-hq:developfrom Nov 28, 2019
Merged
Conversation
Signed-off-by: Aaron Raimist <aaron@raim.ist>
Contributor
|
@aaronraimist can you add screenshots to this PR please to make it easier to review? Thanks! |
Member
|
@nadonomy there's not much to screenshot, it's removing the identity server from the case mentioned in this comment: #11543 (comment) |
nadonomy
reviewed
Nov 28, 2019
Contributor
nadonomy
left a comment
There was a problem hiding this comment.
Gotcha, in that case then all good.
Even though the change is trivial, the screenshot aids context massively for folk (in this case, me!) jumping in from different contexts, rather than having to guess or check out what line 336 in a random file was doing.
LGTM visually, but will let yourself @turt2live approve/merge in case you have other requests.
turt2live
approved these changes
Nov 28, 2019
Member
turt2live
left a comment
There was a problem hiding this comment.
Code lgtm, waiting on the CI to be happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11543