Merged
Conversation
When building the Docker image on amd64, canvas can be installed from a pre-built binary. When building on an another architecture, however, such as arm (e.g. on a Raspberry Pi), these binaries need to be built locally, as per https://www.npmjs.com/package/canvas#compiling. These added dependencies facilitate this. See also, issue element-hq#14400. Signed-off-by: Matt Cengia <mattcen@mattcen.com>
When trying to build the Docker image, I kept receiving an out-of-memory error from Webpack. This issue is apparently explained at webpack/webpack#1914. Several comments in the issue suggested using Node 12 or above. Doing so resolved this issue for me. Signed-off-by: Matt Cengia <mattcen@mattcen.com>
jryans
reviewed
Jul 17, 2020
Collaborator
|
@mattcen Just a nudge to add a comment as mentioned above, and then we should be ready to merge this. Thanks for working on it! |
Contributor
Author
|
@jryans Ah, sorry, I missed your last comment about this; have just pushed another commit with a comment in it. |
Signed-off-by: Matt Cengia <mattcen@mattcen.com>
8add0e9 to
86185e8
Compare
jryans
approved these changes
Jul 31, 2020
Collaborator
jryans
left a comment
There was a problem hiding this comment.
Thanks for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
History is at: https://matrix.to/#/!YTvKGNlinIzlkMTVRl:matrix.org/$4Se7Bpo2lakGZLGxnsXA8WQlCHtMLrJRs8qiNshzBKA?via=matrix.org&via=privacytools.io&via=mozilla.org
(Transcript below)
In short, trying to build an Arm binary of the Docker image for riot-web on either a Raspberry Pi 3 or a MacBook via Docker buildx, there are no pre-built binaries available for
canvas, and building it causeswebpackto run out of memory. These two commits seem to rectify these issues.Chat transcript
Matt Cengia (he/him/his)
Michael (t3chguy)
Matt Cengia (he/him/his)
Michael (t3chguy)