Skip to content

Commit a83b53b

Browse files
author
Alejandro Gómez
committed
add Pull Request to Issue resources
1 parent 981b225 commit a83b53b

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

pygithub3/resources/issues.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@
55

66
from .base import Resource
77
from .users import User
8+
from .pull_requests import PullRequest
89

910

1011
class Label(Resource):
12+
1113
@staticmethod
1214
def is_valid_color(color):
1315
valid_color = re.compile(r'[0-9abcdefABCDEF]{6}')
@@ -21,6 +23,7 @@ def __str__(self):
2123

2224

2325
class Milestone(Resource):
26+
2427
_dates = ('created_at', 'due_on')
2528
_maps = {'creator': User}
2629

@@ -30,8 +33,15 @@ def __str__(self):
3033

3134
class Issue(Resource):
3235

33-
_dates = ('created_at', 'updated_at')
34-
_maps = {'assignee': User, 'user': User}
36+
_dates = ('created_at', 'updated_at', 'closed_at')
37+
_maps = {
38+
'assignee': User,
39+
'user': User,
40+
'milestone': Milestone,
41+
'pull_request': PullRequest
42+
}
43+
44+
_collection_maps = {'labels': Label}
3545

3646
def __str__(self):
3747
return '<Issue (%s)>' % getattr(self, 'number', '')

pygithub3/tests/resources/test_issues.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
class TestLabel(TestCase):
1010
def test_is_valid_color(self):
11-
valid_colors = ['BADA55', 'FFFFFF', '45DFCA']
11+
valid_colors = ['BADa55', 'FF42FF', '45DFCA']
1212
for color in valid_colors:
1313
self.assertTrue(Label.is_valid_color(color))
1414

0 commit comments

Comments
 (0)